Skip to content

Update Algolia Insights Destination #6808

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Aug 13, 2024
Merged

Update Algolia Insights Destination #6808

merged 6 commits into from
Aug 13, 2024

Conversation

jkaho
Copy link
Contributor

@jkaho jkaho commented Jul 11, 2024 •
edited
Loading

Proposed changes

  • Include missing information like the fact that we have default mappings for Product List Filtered and Product Added events
  • Add a Algolia-related data heading to organise content better
  • Use correct event property names in code snippet examples
  • Fix grammar and wording nits, e.g., make the Getting started list look more like the other destinations' docs
  • Clean up screenshots

Merge timing

ASAP

@netlify Netlify
Copy link

netlify bot commented Jul 11, 2024 •
edited
Loading

✅ Deploy Preview for segment-docs ready!

Name Link
🔨 Latest commit 36c9b07
🔍 Latest deploy log https://app.netlify.com/sites/segment-docs/deploys/668feda3cfa53f0008d32e3b
😎 Deploy Preview https://deploy-preview-6808--segment-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@jkaho jkaho marked this pull request as ready for review July 11, 2024 14:42
@jkaho jkaho requested a review from a team as a code owner July 11, 2024 14:42
@jkaho jkaho requested a review from pwseg July 11, 2024 14:42
@wwalser
Copy link
Contributor

wwalser commented Aug 12, 2024

@joe-ayoub-segment is there someone that you can ping to get eyes on this?

@joe-ayoub-segment
Copy link
Contributor

@joe-ayoub-segment is there someone that you can ping to get eyes on this?

Hi @wwalser I'll poke someone on the Docs team about this now

@forstisabella forstisabella added the new-integration Added a new source or destination label Aug 13, 2024
@pwseg pwseg changed the title update algolia insights destination docs Update Algolia Insights Destination Aug 13, 2024
@pwseg pwseg added content-update updates to content that are not new features, includes grammar fixes, added notes and removed new-integration Added a new source or destination labels Aug 13, 2024
@pwseg pwseg merged commit 366fd29 into segmentio:develop Aug 13, 2024
1 check passed
@github-actions GitHub Actions
Copy link
Contributor

Thank you for your contribution! Your pull request is merged, but may take a day or two to appear on the site.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pwseg pwseg pwseg approved these changes

+1 more reviewer

@tcgilbert tcgilbert tcgilbert approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
content-update updates to content that are not new features, includes grammar fixes, added notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@jkaho @wwalser @joe-ayoub-segment @tcgilbert @pwseg @forstisabella